Discussion:
RFR 8058855: Update java.util.zip tests to work with modular image
Amy Lu
2014-10-09 05:15:41 UTC
Permalink
Two java/util/zip tests use JDK rt.jar in test, this fix is to remove
this dependency from test because with a modular rt.jar and the other
JAR files in the JDK go away.

bug: https://bugs.openjdk.java.net/browse/JDK-8058855
webrev: http://cr.openjdk.java.net/~tyan/amylu/8058855/webrev.00/

Thanks,
Amy
David Holmes
2014-10-09 05:23:15 UTC
Permalink
Hi Amy,
Post by Amy Lu
Two java/util/zip tests use JDK rt.jar in test, this fix is to remove
this dependency from test because with a modular rt.jar and the other
JAR files in the JDK go away.
bug: https://bugs.openjdk.java.net/browse/JDK-8058855
webrev: http://cr.openjdk.java.net/~tyan/amylu/8058855/webrev.00/
test/java/util/zip/InterruptibleZip.java

Where is input.jar coming from?

test/java/util/zip/ZipFile/FinalizeZipFile.java

The File variable "lib" is no longer suitably named.

Cheers,
David
Post by Amy Lu
Thanks,
Amy
Amy Lu
2014-10-09 05:50:11 UTC
Permalink
Post by David Holmes
Hi Amy,
Post by Amy Lu
Two java/util/zip tests use JDK rt.jar in test, this fix is to remove
this dependency from test because with a modular rt.jar and the other
JAR files in the JDK go away.
bug: https://bugs.openjdk.java.net/browse/JDK-8058855
webrev: http://cr.openjdk.java.net/~tyan/amylu/8058855/webrev.00/
test/java/util/zip/InterruptibleZip.java
Where is input.jar coming from?
It's an existing jar file in test dir.
Post by David Holmes
test/java/util/zip/ZipFile/FinalizeZipFile.java
The File variable "lib" is no longer suitably named.
Updated name "lib" to "testdir":
http://cr.openjdk.java.net/~weijun/8058855/webrev.01/

Thanks,
Amy
Post by David Holmes
Cheers,
David
Post by Amy Lu
Thanks,
Amy
Xueming Shen
2014-10-09 16:56:00 UTC
Permalink
Post by Amy Lu
Post by David Holmes
Hi Amy,
Post by Amy Lu
Two java/util/zip tests use JDK rt.jar in test, this fix is to remove
this dependency from test because with a modular rt.jar and the other
JAR files in the JDK go away.
bug: https://bugs.openjdk.java.net/browse/JDK-8058855
webrev: http://cr.openjdk.java.net/~tyan/amylu/8058855/webrev.00/
test/java/util/zip/InterruptibleZip.java
Where is input.jar coming from?
It's an existing jar file in test dir.
Post by David Holmes
test/java/util/zip/ZipFile/FinalizeZipFile.java
The File variable "lib" is no longer suitably named.
http://cr.openjdk.java.net/~weijun/8058855/webrev.01/
Thanks,
Amy
looks fine.
Alan Bateman
2014-10-11 12:43:20 UTC
Permalink
Post by Amy Lu
http://cr.openjdk.java.net/~weijun/8058855/webrev.01/
Thanks for taking this one, the updated version looks good to me too.

-Alan
David Holmes
2014-10-13 01:29:12 UTC
Permalink
Post by Amy Lu
Post by David Holmes
Hi Amy,
Post by Amy Lu
Two java/util/zip tests use JDK rt.jar in test, this fix is to remove
this dependency from test because with a modular rt.jar and the other
JAR files in the JDK go away.
bug: https://bugs.openjdk.java.net/browse/JDK-8058855
webrev: http://cr.openjdk.java.net/~tyan/amylu/8058855/webrev.00/
test/java/util/zip/InterruptibleZip.java
Where is input.jar coming from?
It's an existing jar file in test dir.
Is it copied-there/created-by some other part of the test?
Post by Amy Lu
Post by David Holmes
test/java/util/zip/ZipFile/FinalizeZipFile.java
The File variable "lib" is no longer suitably named.
http://cr.openjdk.java.net/~weijun/8058855/webrev.01/
Thanks,
David
Post by Amy Lu
Thanks,
Amy
Post by David Holmes
Cheers,
David
Post by Amy Lu
Thanks,
Amy
Amy Lu
2014-10-13 03:08:02 UTC
Permalink
Post by David Holmes
Post by Amy Lu
Post by David Holmes
Hi Amy,
Post by Amy Lu
Two java/util/zip tests use JDK rt.jar in test, this fix is to remove
this dependency from test because with a modular rt.jar and the other
JAR files in the JDK go away.
bug: https://bugs.openjdk.java.net/browse/JDK-8058855
webrev: http://cr.openjdk.java.net/~tyan/amylu/8058855/webrev.00/
test/java/util/zip/InterruptibleZip.java
Where is input.jar coming from?
It's an existing jar file in test dir.
Is it copied-there/created-by some other part of the test?
No
http://hg.openjdk.java.net/jdk9/dev/jdk/log/tip/test/java/util/zip/input.jar

Thanks,
Amy
Post by David Holmes
Post by Amy Lu
Post by David Holmes
test/java/util/zip/ZipFile/FinalizeZipFile.java
The File variable "lib" is no longer suitably named.
http://cr.openjdk.java.net/~weijun/8058855/webrev.01/
Thanks,
David
Post by Amy Lu
Thanks,
Amy
Post by David Holmes
Cheers,
David
Post by Amy Lu
Thanks,
Amy
David Holmes
2014-10-13 03:33:54 UTC
Permalink
Post by Amy Lu
Post by David Holmes
Post by Amy Lu
Post by David Holmes
Hi Amy,
Post by Amy Lu
Two java/util/zip tests use JDK rt.jar in test, this fix is to remove
this dependency from test because with a modular rt.jar and the other
JAR files in the JDK go away.
bug: https://bugs.openjdk.java.net/browse/JDK-8058855
webrev: http://cr.openjdk.java.net/~tyan/amylu/8058855/webrev.00/
test/java/util/zip/InterruptibleZip.java
Where is input.jar coming from?
It's an existing jar file in test dir.
Is it copied-there/created-by some other part of the test?
No
http://hg.openjdk.java.net/jdk9/dev/jdk/log/tip/test/java/util/zip/input.jar
Thanks - I was looking in the wrong place. I was thinking that this:

System.getProperty("test.src", ".")

would return the top-level test directory, but it will return the actual
source directory for the current test.

David
Post by Amy Lu
Thanks,
Amy
Post by David Holmes
Post by Amy Lu
Post by David Holmes
test/java/util/zip/ZipFile/FinalizeZipFile.java
The File variable "lib" is no longer suitably named.
http://cr.openjdk.java.net/~weijun/8058855/webrev.01/
Thanks,
David
Post by Amy Lu
Thanks,
Amy
Post by David Holmes
Cheers,
David
Post by Amy Lu
Thanks,
Amy
Amy Lu
2014-10-13 03:38:17 UTC
Permalink
Thank you David, Alan and Sherman for your review.
And thank you Alan for sponsor this for me.

Thanks,
Amy
Post by David Holmes
Post by Amy Lu
Post by David Holmes
Post by Amy Lu
Post by David Holmes
Hi Amy,
Post by Amy Lu
Two java/util/zip tests use JDK rt.jar in test, this fix is to remove
this dependency from test because with a modular rt.jar and the other
JAR files in the JDK go away.
bug: https://bugs.openjdk.java.net/browse/JDK-8058855
webrev: http://cr.openjdk.java.net/~tyan/amylu/8058855/webrev.00/
test/java/util/zip/InterruptibleZip.java
Where is input.jar coming from?
It's an existing jar file in test dir.
Is it copied-there/created-by some other part of the test?
No
http://hg.openjdk.java.net/jdk9/dev/jdk/log/tip/test/java/util/zip/input.jar
System.getProperty("test.src", ".")
would return the top-level test directory, but it will return the
actual source directory for the current test.
David
Post by Amy Lu
Thanks,
Amy
Post by David Holmes
Post by Amy Lu
Post by David Holmes
test/java/util/zip/ZipFile/FinalizeZipFile.java
The File variable "lib" is no longer suitably named.
http://cr.openjdk.java.net/~weijun/8058855/webrev.01/
Thanks,
David
Post by Amy Lu
Thanks,
Amy
Post by David Holmes
Cheers,
David
Post by Amy Lu
Thanks,
Amy
Loading...