Discussion:
[8u40] Request for approval and review: JDK-8058733: [TESTBUG] java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java and LFMultiThreadCachingTest.java failed on some platforms due to java.lang.VirtualMachineError
Konstantin Shefov
2014-10-13 14:22:13 UTC
Permalink
Hello,

Please review and approve the backport of the test bug fix to 8u40

The webrev is slightly different from that for JDK 9, because there is
no segmented code cache feature in 8u40.

The bug: https://bugs.openjdk.java.net/browse/JDK-8058695
The 8u40 webrev: http://cr.openjdk.java.net/~kshefov/8058733/webrev.01

JDK 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/5c507b7ee225
Review thread:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-October/029062.html
http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-October/029033.html

Thanks

-Konstantin
Vladimir Ivanov
2014-10-13 15:04:56 UTC
Permalink
Looks good (not a Reviewer).

Best regards,
Vladimir Ivanov
Post by Konstantin Shefov
Hello,
Please review and approve the backport of the test bug fix to 8u40
The webrev is slightly different from that for JDK 9, because there is
no segmented code cache feature in 8u40.
The bug: https://bugs.openjdk.java.net/browse/JDK-8058695
The 8u40 webrev: http://cr.openjdk.java.net/~kshefov/8058733/webrev.01
JDK 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/5c507b7ee225
http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-October/029062.html
http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-October/029033.html
Thanks
-Konstantin
Konstantin Shefov
2014-10-14 08:26:24 UTC
Permalink
Gently reminder
Please, review

-Konstantin
Post by Vladimir Ivanov
Looks good (not a Reviewer).
Best regards,
Vladimir Ivanov
Post by Konstantin Shefov
Hello,
Please review and approve the backport of the test bug fix to 8u40
The webrev is slightly different from that for JDK 9, because there is
no segmented code cache feature in 8u40.
The bug: https://bugs.openjdk.java.net/browse/JDK-8058695
The 8u40 webrev: http://cr.openjdk.java.net/~kshefov/8058733/webrev.01
http://hg.openjdk.java.net/jdk9/dev/jdk/rev/5c507b7ee225
http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-October/029062.html
http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-October/029033.html
Thanks
-Konstantin
Paul Sandoz
2014-10-14 10:50:56 UTC
Permalink
Post by Konstantin Shefov
Gently reminder
Please, review
+1

Paul.
Post by Konstantin Shefov
-Konstantin
Post by Vladimir Ivanov
Looks good (not a Reviewer).
Best regards,
Vladimir Ivanov
Post by Konstantin Shefov
Hello,
Please review and approve the backport of the test bug fix to 8u40
The webrev is slightly different from that for JDK 9, because there is
no segmented code cache feature in 8u40.
The bug: https://bugs.openjdk.java.net/browse/JDK-8058695
The 8u40 webrev: http://cr.openjdk.java.net/~kshefov/8058733/webrev.01
JDK 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/5c507b7ee225
http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-October/029062.html
http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-October/029033.html
Thanks
-Konstantin
Konstantin Shefov
2014-10-16 08:51:53 UTC
Permalink
Sean, Rob

I have to reviews of this backport request (Vladimir is jdk 9 reviewer,
but not 8u40).
Can I get an approval for 8u40 in this case?

Thanks
-Konstantin
Post by Konstantin Shefov
Gently reminder
Please, review
+1
Paul.
Post by Konstantin Shefov
-Konstantin
Post by Vladimir Ivanov
Looks good (not a Reviewer).
Best regards,
Vladimir Ivanov
Post by Konstantin Shefov
Hello,
Please review and approve the backport of the test bug fix to 8u40
The webrev is slightly different from that for JDK 9, because there is
no segmented code cache feature in 8u40.
The bug: https://bugs.openjdk.java.net/browse/JDK-8058695
The 8u40 webrev: http://cr.openjdk.java.net/~kshefov/8058733/webrev.01
JDK 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/5c507b7ee225
http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-October/029062.html
http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-October/029033.html
Thanks
-Konstantin
Seán Coffey
2014-10-16 08:58:46 UTC
Permalink
Approved for jdk8u-dev.

regards,
Sean.
Post by Konstantin Shefov
Sean, Rob
I have to reviews of this backport request (Vladimir is jdk 9
reviewer, but not 8u40).
Can I get an approval for 8u40 in this case?
Thanks
-Konstantin
On Oct 14, 2014, at 10:26 AM, Konstantin Shefov
Post by Konstantin Shefov
Gently reminder
Please, review
+1
Paul.
Post by Konstantin Shefov
-Konstantin
Post by Vladimir Ivanov
Looks good (not a Reviewer).
Best regards,
Vladimir Ivanov
Post by Konstantin Shefov
Hello,
Please review and approve the backport of the test bug fix to 8u40
The webrev is slightly different from that for JDK 9, because there is
no segmented code cache feature in 8u40.
The bug: https://bugs.openjdk.java.net/browse/JDK-8058695
http://cr.openjdk.java.net/~kshefov/8058733/webrev.01
http://hg.openjdk.java.net/jdk9/dev/jdk/rev/5c507b7ee225
http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-October/029062.html
http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-October/029033.html
Thanks
-Konstantin
Loading...