Discussion:
[9] Review request : JDK-8058733: [TESTBUG] java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java and LFMultiThreadCachingTest.java failed on some platforms due to java.lang.VirtualMachineError
Konstantin Shefov
2014-10-08 13:15:47 UTC
Permalink
Hello,

Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8058733
Webrev is http://cr.openjdk.java.net/~kshefov/8058733/webrev.00/

Thanks

-Konstantin
Vladimir Ivanov
2014-10-08 13:24:42 UTC
Permalink
Konstantin,

What kind of testing have you done to verify the fix?

Best regards,
Vladimir Ivanov
Post by Konstantin Shefov
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8058733
Webrev is http://cr.openjdk.java.net/~kshefov/8058733/webrev.00/
Thanks
-Konstantin
Konstantin Shefov
2014-10-08 13:32:41 UTC
Permalink
I have run the test with the latest JDK 9 nightly build from Jenkins
http://scaaa114.us.oracle.com:8080/job/jdk9-dev-test/ws/build/linux-x86_64-normal-server-release

I have tried with different -XX:ReservedCodeCacheSize values. I have
noticed that code cache consumption almost linearly depends on the
number of iterations, so I take the number of iterations according to
the code cache size. I take the number of iterations twice smaller than
the limit (defined by the dependency) to ensure test's stability.

I also can run the test on other OSs (Win, Mac).

-Konstantin
Post by Vladimir Ivanov
Konstantin,
What kind of testing have you done to verify the fix?
Best regards,
Vladimir Ivanov
Post by Konstantin Shefov
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8058733
Webrev is http://cr.openjdk.java.net/~kshefov/8058733/webrev.00/
Thanks
-Konstantin
Daniel Fuchs
2014-10-08 13:25:02 UTC
Permalink
Hi Konstantin,

I'm not qualified as a (R)eviewer for changes in this area,
but I believe you can do:

HotSpotDiagnosticMXBean mbean =
ManagementFactory.getPlatformMXBean(HotSpotDiagnosticMXBean.class);

to get a handle on the MBean. You don't need to go through
the MBeanServer and newPlatformMXBeanProxy stuff...

best regards,

-- daniel
Post by Konstantin Shefov
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8058733
Webrev is http://cr.openjdk.java.net/~kshefov/8058733/webrev.00/
Thanks
-Konstantin
Konstantin Shefov
2014-10-08 14:38:05 UTC
Permalink
Daniel,
Thanks for your comment

Here is the updated webrev:
http://cr.openjdk.java.net/~kshefov/8058733/webrev.01

-Konstantin
Post by Daniel Fuchs
Hi Konstantin,
I'm not qualified as a (R)eviewer for changes in this area,
HotSpotDiagnosticMXBean mbean =
ManagementFactory.getPlatformMXBean(HotSpotDiagnosticMXBean.class);
to get a handle on the MBean. You don't need to go through
the MBeanServer and newPlatformMXBeanProxy stuff...
best regards,
-- daniel
Post by Konstantin Shefov
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8058733
Webrev is http://cr.openjdk.java.net/~kshefov/8058733/webrev.00/
Thanks
-Konstantin
Joe Darcy
2014-10-08 17:25:25 UTC
Permalink
Hello,

I approve this change going into jdk9/dev contingent on the failing
tests passing as modified.

Thanks,

-Joe
Post by Konstantin Shefov
Daniel,
Thanks for your comment
http://cr.openjdk.java.net/~kshefov/8058733/webrev.01
-Konstantin
Post by Daniel Fuchs
Hi Konstantin,
I'm not qualified as a (R)eviewer for changes in this area,
HotSpotDiagnosticMXBean mbean =
ManagementFactory.getPlatformMXBean(HotSpotDiagnosticMXBean.class);
to get a handle on the MBean. You don't need to go through
the MBeanServer and newPlatformMXBeanProxy stuff...
best regards,
-- daniel
Post by Konstantin Shefov
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8058733
Webrev is http://cr.openjdk.java.net/~kshefov/8058733/webrev.00/
Thanks
-Konstantin
Konstantin Shefov
2014-10-09 08:44:44 UTC
Permalink
Hi,

I have updated the webrev to take into account the JDK 9 new feature
with segmented code cache.
http://cr.openjdk.java.net/~kshefov/8058733/webrev.02

Please, review.

-Konstantin
Post by Konstantin Shefov
Hello,
I approve this change going into jdk9/dev contingent on the failing
tests passing as modified.
Thanks,
-Joe
Post by Konstantin Shefov
Daniel,
Thanks for your comment
http://cr.openjdk.java.net/~kshefov/8058733/webrev.01
-Konstantin
Post by Daniel Fuchs
Hi Konstantin,
I'm not qualified as a (R)eviewer for changes in this area,
HotSpotDiagnosticMXBean mbean =
ManagementFactory.getPlatformMXBean(HotSpotDiagnosticMXBean.class);
to get a handle on the MBean. You don't need to go through
the MBeanServer and newPlatformMXBeanProxy stuff...
best regards,
-- daniel
Post by Konstantin Shefov
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8058733
Webrev is http://cr.openjdk.java.net/~kshefov/8058733/webrev.00/
Thanks
-Konstantin
Joe Darcy
2014-10-09 15:56:38 UTC
Permalink
Looks fine Konstantin.

(These tests have been failing very often since they were pushed. If
your fix isn't pushed today, I'd argue for the tests being excluded.)

Thanks,

-Joe
Post by Konstantin Shefov
Hi,
I have updated the webrev to take into account the JDK 9 new feature
with segmented code cache.
http://cr.openjdk.java.net/~kshefov/8058733/webrev.02
Please, review.
-Konstantin
Post by Konstantin Shefov
Hello,
I approve this change going into jdk9/dev contingent on the failing
tests passing as modified.
Thanks,
-Joe
Post by Konstantin Shefov
Daniel,
Thanks for your comment
http://cr.openjdk.java.net/~kshefov/8058733/webrev.01
-Konstantin
Post by Daniel Fuchs
Hi Konstantin,
I'm not qualified as a (R)eviewer for changes in this area,
HotSpotDiagnosticMXBean mbean =
ManagementFactory.getPlatformMXBean(HotSpotDiagnosticMXBean.class);
to get a handle on the MBean. You don't need to go through
the MBeanServer and newPlatformMXBeanProxy stuff...
best regards,
-- daniel
Post by Konstantin Shefov
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8058733
Webrev is http://cr.openjdk.java.net/~kshefov/8058733/webrev.00/
Thanks
-Konstantin
Konstantin Shefov
2014-10-10 08:39:16 UTC
Permalink
Gently reminder
Post by Joe Darcy
Looks fine Konstantin.
(These tests have been failing very often since they were pushed. If
your fix isn't pushed today, I'd argue for the tests being excluded.)
Please, review
Post by Joe Darcy
Thanks,
-Joe
Post by Konstantin Shefov
Hi,
I have updated the webrev to take into account the JDK 9 new feature
with segmented code cache.
http://cr.openjdk.java.net/~kshefov/8058733/webrev.02
Please, review.
-Konstantin
Post by Konstantin Shefov
Hello,
I approve this change going into jdk9/dev contingent on the failing
tests passing as modified.
Thanks,
-Joe
Post by Konstantin Shefov
Daniel,
Thanks for your comment
http://cr.openjdk.java.net/~kshefov/8058733/webrev.01
-Konstantin
Post by Daniel Fuchs
Hi Konstantin,
I'm not qualified as a (R)eviewer for changes in this area,
HotSpotDiagnosticMXBean mbean =
ManagementFactory.getPlatformMXBean(HotSpotDiagnosticMXBean.class);
to get a handle on the MBean. You don't need to go through
the MBeanServer and newPlatformMXBeanProxy stuff...
best regards,
-- daniel
Post by Konstantin Shefov
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8058733
Webrev is http://cr.openjdk.java.net/~kshefov/8058733/webrev.00/
Thanks
-Konstantin
Vladimir Ivanov
2014-10-10 15:06:12 UTC
Permalink
Looks good.

Best regards,
Vladimir Ivanov
Post by Konstantin Shefov
Hi,
I have updated the webrev to take into account the JDK 9 new feature
with segmented code cache.
http://cr.openjdk.java.net/~kshefov/8058733/webrev.02
Please, review.
-Konstantin
Post by Konstantin Shefov
Hello,
I approve this change going into jdk9/dev contingent on the failing
tests passing as modified.
Thanks,
-Joe
Post by Konstantin Shefov
Daniel,
Thanks for your comment
http://cr.openjdk.java.net/~kshefov/8058733/webrev.01
-Konstantin
Post by Daniel Fuchs
Hi Konstantin,
I'm not qualified as a (R)eviewer for changes in this area,
HotSpotDiagnosticMXBean mbean =
ManagementFactory.getPlatformMXBean(HotSpotDiagnosticMXBean.class);
to get a handle on the MBean. You don't need to go through
the MBeanServer and newPlatformMXBeanProxy stuff...
best regards,
-- daniel
Post by Konstantin Shefov
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8058733
Webrev is http://cr.openjdk.java.net/~kshefov/8058733/webrev.00/
Thanks
-Konstantin
Konstantin Shefov
2014-10-10 17:31:02 UTC
Permalink
Thanks for reviewing! Pushed.

-Konstantin
Post by Vladimir Ivanov
Looks good.
Best regards,
Vladimir Ivanov
Post by Konstantin Shefov
Hi,
I have updated the webrev to take into account the JDK 9 new feature
with segmented code cache.
http://cr.openjdk.java.net/~kshefov/8058733/webrev.02
Please, review.
-Konstantin
Post by Konstantin Shefov
Hello,
I approve this change going into jdk9/dev contingent on the failing
tests passing as modified.
Thanks,
-Joe
Post by Konstantin Shefov
Daniel,
Thanks for your comment
http://cr.openjdk.java.net/~kshefov/8058733/webrev.01
-Konstantin
Post by Daniel Fuchs
Hi Konstantin,
I'm not qualified as a (R)eviewer for changes in this area,
HotSpotDiagnosticMXBean mbean =
ManagementFactory.getPlatformMXBean(HotSpotDiagnosticMXBean.class);
to get a handle on the MBean. You don't need to go through
the MBeanServer and newPlatformMXBeanProxy stuff...
best regards,
-- daniel
Post by Konstantin Shefov
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8058733
Webrev is http://cr.openjdk.java.net/~kshefov/8058733/webrev.00/
Thanks
-Konstantin
Loading...